feat: adds flex groups dropdown menu in assignment modal #1335
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
katrinan029
changed the title
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #1335 +/- ##
=======================================
Coverage 85.72% 85.73%
=======================================
Files 594 597 +3
Lines 12977 13071 +94
Branches 2704 2766 +62
=======================================
+ Hits 11125 11206 +81
- Misses 1792 1800 +8
- Partials 60 65 +5 ☔ View full report in Codecov by Sentry. |
katrinan029
force-pushed
the
knguyen2/ent-9491
branch
from
73d8370 to
8c81642
Compare
src/components/learner-credit-management/assignment-modal/AssignmentModalContent.jsx
Outdated
Show resolved
Hide resolved
marlonkeating
requested changes
Oct 29, 2024
src/components/learner-credit-management/data/hooks/useEnterpriseFlexGroups.js
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/data/hooks/useEnterpriseFlexGroups.js
Outdated
Show resolved
Hide resolved
src/components/learner-credit-management/data/hooks/useEnterpriseFlexGroups.js
Show resolved
Hide resolved
katrinan029
force-pushed
the
knguyen2/ent-9491
branch
from
35409ec to
f1f38ee
Compare
marlonkeating
approved these changes
Oct 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Adds support for admins to select flex groups from the dropdown menu to the Learner credit assignment modal. The members associated with that group will be added to the summary tab once the user clicks the
Apply selectionsbutton.If a group does not have any flex groups, the dropdown will not be shown.
https://2u-internal.atlassian.net/browse/ENT-9491
Screen.Recording.2024-10-22.at.4.52.11.PM.mov
Test scenarios
Apply selectionsbutton and navigates away from the dropdown menu, the selections will clear. The same should apply when the user unchecks a group that was previously added to the summary tab -- previous selections/unselections should persist until the user clicks the 'Apply selections' button.For all changes
Only if submitting a visual change